basecamp/marginalia

NoMethodError: undefined method `helper' for ActionController::API:Class

ryanstuhl805 opened this issue · 3 comments

ryanstuhl805 commented

When I try to install the gem as is, I get the error in the issue title. Is anyone else getting the same error?

I've looked into this error and it sounds like instead of using ActiveSupport.on_load :action_controller do on lib/marginalia/railtie.rb:13 it should be using ActiveSupport.on_load :action_controller_base do. Can someone confirm this?

arthurnn commented

Which Rails version are you using?

ryanstuhl805 commented

I'm running rails 5.2.3 and ruby 2.3.7. I found this PR on a different Gem referencing the same error message I encountered which is why I think the action_controller needs to be action_controller_base. Perhaps this is a >= Rails 5 compatibility issue?

sj26 commented

Marginalia doesn't include any references to helper. The test suite confirms compatibility with Rails 5.2 and 6.0.

Perhaps this issue is stale? Please reopen if you're still experiencing this error, and please include a full backtrace and relevant versions.