basho-labs/riak-chef-cookbook

Don't use pam_limits for file descriptor limits

Closed this issue · 7 comments

mfischer-zd commented

The use of pam_limits for Enterprise Linux variants isn't needed. Explicit ulimit declarations should always be made in the startup scripts (or scripts they source, such as /etc/default/service or /etc/sysconfig/service) for daemons. pam_limits should be used only for interactive user sessions, which is irrelevant for a service such as Riak.

jaredmorrow commented

This will be fixed in Riak 2.0.0 pre18 and any newer version, thanks for reporting it

cheeseplus commented

Now that 2.0 is out I'll do a pass for RHEL/CentOS to bring feature parity as this is already supported on Debian based platforms. One downside is that due to upstream changes in node_package, userland tools will always complain about file limits as they don't source /etc/defaults/riak

seancribbs commented

@cheeseplus We should look into fixing node_package to properly handle this for the 2.1 series. Any ideas you have would be helpful.

cheeseplus commented

@seancribbs so there are two issues here

  1. Fixing the riak users ulimit via /etc/default/riak (already doing this in cookbook) or /etc/sysconfig/riak as part of the riak package
  2. Having the userspace riak tools either not check the ulimit or have them source the same ulimit scripts mentioned above as currently you'll get warning unless you run via the startup script
cheeseplus commented

So given that this needs to be fixed upstream (it might already) I am closing this issue out but welcome to re-opening it in the future.