basho-labs/riak-chef-cookbook

Factor computation logic out of attributes

Closed this issue · 3 comments

Stuff like: https://github.com/basho/riak-chef-cookbook/blob/master/attributes/default.rb#L62
Make it harder for an override attribute to be used at another precedence level, without having the Erlang-specific contexts loaded.

We're currently evaluating dropping the Erlang config format for something a bit simpler and more, well, config like but I don't yet have an ETA on release.

Although it could be clearer in our own Readme, the repo for the erlang_template_helper does document how overrides can be done in JSON and this is what we use both internally and with customers.

It could definitely be simpler but this is as simple as we have been able to get it given the current limitations. If you've got a better idea, by all means throw a PR up and I'll happily test and merge.

This seems tied directly to #51, would you mind if I closed it, essentially merging the issues?

Thanks for following up. One thought I had was keeping all attributes in ruby, writing out a pre-template in json, then running it through the erlang conversion.
Not 100% sure that it's better, but it was a thought.
Totally okay with this issue's closure.