CRC check should be performed before unpacking data

Question

CRC check should be performed before unpacking data

Closed this issue 13 years ago · 3 comments

Currently Bitcask performs a CRC check after unpacking data. This may lead to a badmatch error when unpacking the data if the data is corrupt. Checking the CRC before unpacking the data would avoid this badmatch error.

Relevant section of code:
https://github.com/basho/bitcask/blob/d8958d98d6619a1a8b9e71a7a7b19a7d9fb38ef0/src/bitcask_fileops.erl#L171-181

Answer 1 · 2012-02-04T19:32:23.000Z

I've just created pull request with the fix: #32

Answer 2 · 2012-02-24T19:49:27.000Z

Dan, this issue looks closable, yes?

Answer 3 · 2012-02-24T20:43:58.000Z

yes; this is fixed on master