org-journal test suite failing under emacs 29

Question

org-journal test suite failing under emacs 29

Closed this issue a year ago · 2 comments

jmay commented a year ago

org-journal test suite does not run cleanly (emacs 29.1)

Before I investigate further and work up a fix, I'd like some verification that this isn't just me.

Steps to reproduce the behavior:

installed latest org-journal with elpaca under emacs 29
at terminal cd .emacs.d/elpaca/repos/org-journal
eldev test

Expected behavior
All tests should pass.

Actual behavior

3 unexpected results:
   FAILED  org-journal-carryover-delete-empty-journal-test
   FAILED  org-journal-carryover-items-test
   FAILED  org-journal-scheduled-weekly-test

Desktop (please complete the following information):

OS: MacOS 13.4.1
Emacs 29.1 installed from https://github.com/railwaycat/homebrew-emacsmacport/releases

Answer 1 · 2023-11-20T22:41:30.000Z

I'm seeing the same tests fail during an update using Guix.

starting phase `check'
Running 10 tests (2023-11-20 22:31:34+0000, selector ‘t’)
   passed   1/10  org-journal-calendar-date-from-file-test (0.000712 sec)
Test org-journal-carryover-delete-empty-journal-test backtrace:
  signal(error ("Calling ‘org-fold-core-region’ with missing SPEC"))
  error("Calling `org-fold-core-region' with missing SPEC")
  org-fold-region(35 41 t drawer)
  org-insert-property-drawer()
  org-get-property-block(1 force)
  org-entry-put(nil "CREATED" "20190101")
  org-set-property("CREATED" "20190101")
  (progn (insert "* Wednesday, 01/01/19\n") (org-set-property "CREATED
  (unwind-protect (progn (insert "* Wednesday, 01/01/19\n") (org-set-p
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((buffer "20181231") (org-journal-carryover-delete-empty-journa
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-carryover-delete-empty-jo
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-carryover-delete-empty-journal-test condition:
    (error "Calling ‘org-fold-core-region’ with missing SPEC")
   FAILED   2/10  org-journal-carryover-delete-empty-journal-test (0.219124 sec) at tests/org-journal-test.el:195
Test org-journal-carryover-items-test backtrace:
  signal(error ("Calling ‘org-fold-core-region’ with missing SPEC"))
  error("Calling `org-fold-core-region' with missing SPEC")
  org-fold-region(33 39 t drawer)
  org-insert-property-drawer()
  org-get-property-block(1 force)
  org-entry-put(nil "CREATED" "20190101")
  org-set-property("CREATED" "20190101")
  (progn (insert "* Tuesday, 01/01/19\n") (org-set-property "CREATED" 
  (unwind-protect (progn (insert "* Tuesday, 01/01/19\n") (org-set-pro
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((org-journal-file-type 'weekly) (system-time-locale "C") (buff
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-carryover-items-test :doc
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-carryover-items-test condition:
    (error "Calling ‘org-fold-core-region’ with missing SPEC")
   FAILED   3/10  org-journal-carryover-items-test (0.000366 sec) at tests/org-journal-test.el:120
   passed   4/10  org-journal-carryover-keep-parents-test (0.023941 sec)
   passed   5/10  org-journal-convert-time-to-file-type-time-test (0.000295 sec)
   passed   6/10  org-journal-insert-header-test (0.006430 sec)
   passed   7/10  org-journal-scheduled-carryover-daily-test (0.011099 sec)
   passed   8/10  org-journal-scheduled-carryover-yearly-test (0.014905 sec)
Test org-journal-scheduled-weekly-test backtrace:
  signal(ert-test-failed (((should (equal (buffer-substring-no-propert
  ert-fail(((should (equal (buffer-substring-no-properties (point-min)
  (if (unwind-protect (setq value-104 (apply fn-102 args-103)) (setq f
  (let (form-description-106) (if (unwind-protect (setq value-104 (app
  (let ((value-104 'ert-form-evaluation-aborted-105)) (let (form-descr
  (let* ((fn-102 #'equal) (args-103 (condition-case err (let ((signal-
  (let* ((scheduled-entry-date (calendar-current-date day-offset)) (sc
  (let ((org-journal-file-type 'weekly) (org-journal-start-on-weekday 
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-scheduled-weekly-test :do
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-scheduled-weekly-test condition:
    (ert-test-failed
     ((should
       (equal
        (buffer-substring-no-properties ... ...)
        (with-temp-buffer ... ...)))
      :form
      (equal "* Test header\n:PROPERTIES:\n:CREATED:  20231120\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20231121\n:END:\n** TODO Task 1\n<2023-11-21 Tue 00:00>\n** TODO Task 2\n<2023-11-21 Tue 00:00>" "* Test header\n:PROPERTIES:\n:CREATED:  20231120\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20231121\n:END:\n** TODO Task 1\n2023-11-21 Tue 00:00\n** TODO Task 2\n2023-11-21 Tue 00:00")
      :value nil :explanation
      (arrays-of-different-length 181 177 "* Test header\n:PROPERTIES:\n:CREATED:  20231120\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20231121\n:END:\n** TODO Task 1\n<2023-11-21 Tue 00:00>\n** TODO Task 2\n<2023-11-21 Tue 00:00>" "* Test header\n:PROPERTIES:\n:CREATED:  20231120\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20231121\n:END:\n** TODO Task 1\n2023-11-21 Tue 00:00\n** TODO Task 2\n2023-11-21 Tue 00:00" first-mismatch-at 121)))
   FAILED   9/10  org-journal-scheduled-weekly-test (0.009819 sec) at tests/org-journal-test.el:319
   passed  10/10  org-journal-search-build-file-list-test (0.047456 sec)

Ran 10 tests, 7 results as expected, 3 unexpected (2023-11-20 22:31:35+0000, 0.498731 sec)

3 unexpected results:
   FAILED  org-journal-carryover-delete-empty-journal-test
   FAILED  org-journal-carryover-items-test
   FAILED  org-journal-scheduled-weekly-test

error: in phase 'check': uncaught exception:

This is with Guix's emacs-next-tree-sitter 30.0.50-0.ac7ec87 package.

Answer 2 · 2024-02-18T16:15:33.000Z

Should be fixed! Please reopen if not.