Error loading colour scheme Packages/Ecmascript Syntax/excelsior.tmTheme
nicksspirit opened this issue · 4 comments
When I try to use the excelsior theme from the Ecmascript Sublime Package, I get this:
Running on MacOS High Seirra 10.13.6 and using Sublime Text Build Version 3180
Thanks for the report. The excelsior file was recently moved to another location. As a workaround, you can simply choose that UI color scheme which is located at Packages/Ecmascript Syntax/nested/build/ecmascript (see 2nd list item in screenshot).
The reason there are two files is that this color scheme is now generated during the build process. The location of the old file is now a symbolic link to the generated file, but I can see this is causing an issue when the directory is bundled into a .sublime-package archive. I suppose a remedy for this could be to add those two paths to the files_to_ignore settings so that Package Control will not force the symbolic link into an archive which is likely what is preventing it from resolving to the hard file.
The other option would be to just overwrite the top-level color scheme file with the generated one every time we patch -- but this is dangerous since devs might not realize the file is generated and start editing it. This was the motivation behind creating a symbolic link, also so that existing users would not experience a missing file error message.
@blake-regalia I’ve never looked into how this is done, but fairly often I’ve seen packages display a notice file to communicate new features or breaking changes on upgrade. What are your thoughts on removing the symlink and letting people know how to proceed with a notice like that?
Sounds good to me, i'll get this going
Fixed in v2.0.0