maven_jar should also pull source jars
Closed this issue · 10 comments
most maven jars have a parallel -src.jar available. This is very useful in an IDE as eclipse lets you tie a src-jar to a precompiled-jar.
In mvn that is usually:
mvn eclipse:eclipse -DdownloadSources=true
I would suggest that this should be the default option in bazel, or at least configurable in the maven_jar(..., downloadSrcs = 1)
As mentioned on https://groups.google.com/d/msg/bazel-discuss/25X8NKHv4H8/pS2so6AjJAAJ, downloading the javadoc jar would also be nice.
+1
+1
+1
+1
+1
Why is this P4 priority issue? Quoting Gerrit Code Review priority descriptions: [1], that apparently common for all Google projects:
Priority-4
Ponies and icebox.
Unfortunate: it's a legitimate issue, but the team never plans to fix this.
And even better question: what is the appropriate workaround for this missing feature? What we are surely not going to do is to spam WORKSPACE file with two rule invocations for each and every artifact:
maven_jar(
name = 'javax_validation',
artifact = 'javax.validation:validation-api:1.0.0.GA',
sha1 = 'b6bd7f9d78f6fdaa3c37dae18a4bd298915f328e',
)
http_jar(
name = "javax_validation_src",
url = "http://repo1.maven.org/maven2/javax/validation/validation-api/1.0.0.GA/validation-api-1.0.0.GA-sources.jar",
)
Instead, Skylark maven_jar2 rule that is doing something similar to this maven_jar Bucklet rule would be nice: [2].
P4 is almost that yes. For us it mostly means "It makes sense, we have no time to work on it but we would welcome any contribution to make it happens"
Which is weird because it is P4 and assigned. Anyway, defering to
@kchodorow to reasssess its priority and ping @jin for the reimplementation of maven_jar in skylark.