bazelbuild/rules_android

Migrate to Bzlmod for managing external dependencies

meteorcloudy opened this issue · 4 comments

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check bazelbuild/bazel#18958

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3352#018af627-f96d-4305-bb29-8af240ab7f95
Looks like only two tests failing:

//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/apidescriptors:ExtractApiDescriptorsCommandTest FAILED in 3 out of 3 in 0.4s
//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/sdkdependenciesmanifest:GenerateSdkDependenciesManifestCommandTest FAILED in 3 out of 3 in 0.5s

We need to use the Java runfiles library at

JAVATESTS_DIR.resolve(
Path.of(
"com/google/devtools/build/android/sandboxedsdktoolbox",
"apidescriptors/testlibrary/libtestlibrary.jar"));

Hmm, I thought that all tests under //src/tools were being run in BazelCI already (which should include a bzlmod config): https://github.com/bazelbuild/rules_android/blob/main/.bazelci/presubmit.yml#L7

Curious that there would be tests failing still.