bazelbuild/rules_appengine

`JDK8_JVM_OPTS` is removed from @bazel_tools with Bazel@HEAD

meteorcloudy opened this issue · 5 comments

Breaking change: bazelbuild/bazel@3a0a4f3#diff-d5fecbfa677024171f4ad5ea60ffb5886360d2069f86cd04300e791f5d6617c8

rules_appengine should stop using JDK8_JVM_OPTS due to the above breaking change.

JDK8_JVM_OPTS is only needed if using JDK 8 to run javac. If this toolchain is just trying to target the Java 8 language level (but not require a JDK 8 javac), then it might be sufficient to just drop the use of JDK8_JVM_OPTS

default_java_toolchain(
name = "jdk8",
configuration = JVM8_TOOLCHAIN_CONFIGURATION,
jvm_opts = JDK8_JVM_OPTS + [
"-XX:+TieredCompilation",
"-XX:TieredStopAtLevel=1",
],
source_version = "8",
target_version = "8",

@pmbethe09 is rules_appengine still being maintained?

There has been no active work on this in some time. Unclear if we should try to get support going again.

ACK, then I'll disable rules_appengine in our downstream for now.