bazelbuild/rules_closure

Make rules_closure conform to Style Guide for Rules

Yannic opened this issue · 3 comments

Tracking bug for making rules_closure conform to Bazel's Style Guide for Rules.

Known issues:

  • Dependencies / Toolchains should be declared by rules_closure_{dependencies,toolchains} in closure/repositories.bzl: https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies
  • Tests should live in //tests
  • Repo description should be Closure rules for Bazel
  • Workspace should be named rules_closure (Note: There are probably too many existing users now, so this is going to be a wontFix issue).

@alexeagle Can you handle the repo description issue?

Sure, done, thanks for picking this up.

Thank you!