bazelbuild/rules_typescript

com_github_kylelemons_godebug and com_github_mattn_go_isatty should be loaded with _maybe helper

ashi009 opened this issue · 3 comments

ashi009 commented

com_github_kylelemons_godebug and com_github_mattn_go_isatty are declared directly without using _maybe helper, which may override previously defined go_repository.

(Somehow go_repository with the same name can now be redeclared. Possibly a rules_go bug?)

ashi009 commented

After reading bazelbuild/rules_go#749 this seems reasonable. However, this bazel feature should be documented in big red bold text.

Closing as WAI.

ashi009 commented

Reopening this given the comment by @dslomov, this is a bug and it will break some day.

alexeagle commented

I think this doesn't matter anymore now that we ship pre-compiled Go binaries. Building rules_typescript from source should be an unusual edge case now