enhance the new search function
Closed this issue · 16 comments
BBG's new version(20221001) adds a search function in the theme, which is quite excellent.
However, this function maybe still needs to be improved:
- It cannot recognise the uppercase/lowercase when the title is lowercase/uppercase.
- It cannot search the article content even if I am in an article.
- Maybe not to create a new box to search is a better choice as for me.
- The search bar's font color is hard to be seen in some background colors other than the default color.(from @scientificworld )
Thanks.
Maybe not to create a new box to search is a better choice as for me.
I agree with you.
Oh, by the way... The color of "Search in this site" does not match the text color of the blog title bar, so sometimes it will be hard to recognize it.
e.g. My Blog. The background color of the title bar is #feeeed, and it's difficult to see the white text.
can you assign it to me?
@omriattiya Thank you for your willingness to contribute to bbg.
To enhance the search function, you may want to modify the code in default_theme_src.
@Misaka13514 I made it that casing won't matter for the search. can you please merge it?
@Misaka13514 I made it that casing won't matter for the search. can you please merge it?
Merged in default_theme_src #1.
However, this function maybe still needs to be improved:
- Recognize the uppercase/lowercase when the title is lowercase/uppercase.
- Search the article content.
- Not to create a new box to search.
@omriattiya This issue is not fully resolved, do you have interest in resolving the rest parts?
@Misaka13514 not atm, thanks! Since it's a giant single file, it was hard to work with.. and a lot of Chinese (or other language I don't know) which was also hard to work with. I hope that what I did, indeed help you :)
@omriattiya Okay we know, we may improve on these issues later as well. Thanks for your contribution anyway.
BYN is NB!（）
BYN is NB!（）
I agree with you. ()
Maybe not to create a new box to search is a better choice as for me.
Where do you think the search results should be displayed if there is no search box?
搜索栏下面？
搜索栏下面？
Please show an example site
框着的部分加长搜索框，圈出来的部分显示结果？
或者，点击之后搜索栏变长，圈出来的部分显示结果？（
框着的部分加长搜索框，圈出来的部分显示结果？
或者，点击之后搜索栏变长，圈出来的部分显示结果？（
Hmm, I think the style now is just OK... Implement this will make it more complex, and may behave badly on mobile devices.
Can you give more reasons for using this design?