bblfsh/python-client

Issues with `version()` and `supported_languages()`

vmarkovtsev opened this issue · 4 comments

vmarkovtsev commented

I run the following code and get:

import bblfsh
client = bblfsh.BblfshClient("0.0.0.0:9432")

print(client.version())
elapsed {
}
version: "v2.11.0"
build {
  seconds: -62135596800
}

print(client.supported_languages())
[name: "JavaScript"
language: "javascript"
version: "dev-adcd1b4"
status: "beta"
features: "ast"
features: "uast"
features: "roles"
]

The version string has a negative number of seconds and empty "elapsed".

The javascript driver version is reported to be "dev-adcd1b4", which does not help to check that it is 1.2.0 (which we strictly require since the newer versions do not work for us).

juanjux commented

There are several issues here, neither of those culprit of the poor Python client :)

  • Missing elapsed and negative seconds seems to be a problem with the VersionResponse implementation in bblfshd since the returned value is directly the one from calling VersionRequest on the client without any added code.

  • Bad version for the Javascript driver, seems to be a problem with either the Javascript driver or the SDK (seems to be Ok in the latest drivers).

I'll confirm that the problems are in bblfshd/javascript-driver/sdk and reopen in the right projects adding you to the CC.

  • ❤️1
juanjux commented

I've fixed the "elapsed" problem, as expected it was a bug in bblfshd, looking now at why the elapsed time is empty for that request type which won't be far from that other critter (so I'll tag bblfshd after this second one is fixed).

juanjux commented

Elapsed time problem fixed too. I'll take a look at why the Javascript driver (and not later versions) didn't tag the version correctly in the driver now. Probably a bug in SDK.v1...

juanjux commented

Closing this, I'll open an issue for the javascript driver version.

  • 👍1