Wrong timing calculation code?

[7134956]

nand_programmer/qt/parallel_chip_info.cpp

Line 56 in 7f0379c

std::array<uint32_t, 5> setupArr = { params[CHIP_PARAM_T_CH],

nand_programmer/qt/parallel_chip_info.cpp

Line 59 in 7f0379c

std::array<uint32_t, 3> hiZArr = { params[CHIP_PARAM_T_CH],

nand_programmer/qt/parallel_chip_info.cpp

Line 64 in 7f0379c

/* (SET + 1) * tHCLK >= max(tCH, tCLS, tALS, tCLR, tAR) - tWP */

nand_programmer/qt/parallel_chip_info.cpp

Line 83 in 7f0379c

/* (HIZ + 1) * tHCLK >= max(tCH, tALS, tCLS) + (tWP - tDS) */

This does not match the appnote.
tCH or tCS.

nand_programmer/qt/parallel_chip_info.cpp

Line 72 in 7f0379c

waitSetupTime = std::max(params[CHIP_PARAM_T_WP], params[CHIP_PARAM_T_WP]);

waitSetupTime = std::max(params[CHIP_PARAM_T_WP], params[CHIP_PARAM_T_RP]);

This is how my samsung chips read fine:
7134956@6ec011d

[bbogush]

Good catch. Thank you!