bbrdaric/jsgettext

error: jsgettext.php is not a valid javascript file.

Opened this issue · 1 comments

When I run this from the command line

php jsgettext.php test.js -o test.po

I get "jsgettext.php is not a valid javascript file."

this seems to fix it:

on line 20 of jsgettext.php

- $options['files'][] = $args[$i];
+ if ($i != 0) $options['files'][] = $args[$i];

Original issue reported on code.google.com by reynar...@gmail.com on 27 Jul 2011 at 9:11

The correct change would probably be in line 13, instead of:
 $i = 0;
try:
 $i = 1;

$argv[0] contains the whole command line string so it should not be used:
http://php.net/manual/en/reserved.variables.argv.php
Note: The first argument $argv[0] is always the name that was used to run the 
script.

Original comment by anz...@gmail.com on 16 Dec 2011 at 9:03

  • Added labels: ****
  • Removed labels: ****