bbustin/climaduino

Strange switch in _shortCycleProtection

Opened this issue · 1 comments

alexisfradel commented

Hello,

I've just checked your code and it looks really interesting.
Unfortunately I'm new to Arduino and so I would like to check if I've understood correctly the code.

In the function _shortCycleProtection, why do you use a switch statement since it seems that you do exactly the same thing in both scenarii?

Thanks for the clarification.
Alexis

bbustin commented

Hi Alexis,

I did a double-take when looking at the code. At first I thought it was exactly the same in both cases as well and that the switch statement was an error. Then I looked again and saw why it was there.

If the system is currently running, it makes sure the system stays on for at least minRunTimeMillis. This ensures the system does not only come on for a short period of time and then turn off. If the system is not running, then it makes sure the system has been off for at least minOffTimeMillis. This protects the AC compressor from being damaged by making sure it has been off for long enough before we allow it to come back on.

  • Brian