PR Review Process updates

Question

PR Review Process updates

Closed this issue a year ago · 2 comments

Dianadec commented 2 years ago

Review Process - Summary: what came out of the PR Review Process meeting on Feb 2.

A new pipeline has been added in Zenhub called "Review in Progress"
Before moving a card from "Review in Progress" to "Pending PO Approval", check shipit first to ensure that it is in dev.
Good practice is once you've finished working on a card, check if anything needs to be reviewed before pulling a new card into the sprint

AC:

Updates to the written PR Review process to be added to the cas-home documentation on github.

Check out the team process miro board for more tidbits on what we discussed

Answer 1 · 2023-03-15T20:41:23.000Z

@LindsayMacfarlane @Dianadec the document can be viewed here: https://github.com/bcgov/cas-home/blob/main/docs/version_control/pull-request-review-process.md

Answer 2 · 2023-03-17T23:51:14.000Z

Thank you @Sepehr-Sobhani - this is fantastic and will be really helpful for team members to learn and understand our pr review process. Much appreciated!