bcgov/issuer-kit

Admin UI Feedback - draft

Closed this issue · 2 comments

swcurran commented

Here is my first cut feedback on the Admin UI:

  1. I don't yet know what the various status values are, so need that explained. The split between "invited" and "confirmed" is unclear. For now I think we just have one list, or perhaps, a list of active vs. deactivated users.
  2. When adding:
    1. When leaving the email blank, the error message is "username invalid" - should be at least "email invalid".
    2. Not a fan of the Jurisdiction popup. Please make it inline like Authentication.
    3. Preset the Jurisdiction to BC and the Authentication to GitHub.
    4. Not previously requested but NTH - an optional "Name" field
  3. On the submit screen:
    1. Don't show the URL on the screen. I'm guessing that's debugging stuff left in?
    2. The "Expiry" field should be a date/time and the value should be 24 hours from now.
    3. I assume that the "expired" (whatever is impacted by the "revoked") is not displayed but is part of the status?
  4. The email didn't get sent. I assume that is expected? I'd like to see the email ASAP so that we can write the copy for it.
seanadipose commented
  1. As discussed:
    Pending:
  • sent
  • expired
    Used:
  • logged in
  • issued

*Note: Let's see how you like the latest changes. There is an active/disable on what we would call "used". I'll remove those.
2.i I'll correct that.
2.ii: will change.
2.iii: will change
2.iv will change (I thought this would be something they'd want so was anticipating it)

On the submit screen:

  1. Don't show the URL on the screen. I'm guessing that's debugging stuff left in?
  • In the event that they wanted to just send the link directly to someone as an admin. I'll remove it.
  1. The "Expiry" field should be a date/time and the value should be 24 hours from now.
  • Was just dummy data that I was using while building. Will be correct in future.
  1. I assume that the "expired" (whatever is impacted by the "revoked") is not displayed but is part of the status?
  • this feature wasn't finished. It is now and should be more clear. Revoked is now Enable/Disable access, although I think I should change the wording to Revoke/Grant Access as that's more clear than enable/disable. That feature will set the user to active = false
seanadipose commented

@swcurran Fixes made in #25