bcgov/vc-authn-oidc

Can scan a QR code while it's in Pending state

loneil opened this issue · 5 comments

The mask over the QR code does not obscure it enough to prevent (at least the BC Wallet) from attempting to scan it as a QR code. This can have unintended consequences it seems (depending on BC Wallet build/OS can result in Invalid QR code, or an attempt to do the proof that doesn't work)

This mask should probably obscure the QR code more?

image

For example, on Android (1707) doing multiple scans and then denying the one that comes up can result in:

image

Don't have the issue on "Refresh" state as the text box blocks more

image

Adding an opaque border around the "QR code scanned" will make it look like a button that people may click. I would suggest blurring the QR code or simply increase the transparency (make the qr code lighter). Also, there's a transparency treatment on the text as well, that should be removed.

@loneil if the effort is not significant let's implement Kim's recommendations before we close the issue.

Changes in #540
QR is lighter and unscannable. Text is normal opaque text now so no button confusion