bcoin-org/bcoin

node_modules should be removed from the repo

haxwell opened this issue · 5 comments

Usually, node_modules should not be checked in to the repo.

If anyone needs it, they can just run npm install.

I suggest we remove it, and add the entire node_modules/ directory to the .gitignore.

Also, we should add .idea/ to the .gitignore (intellij project files).

Please read #905

Noted! I understand why node_modules/ is committed to the repo.

What are your thoughts on adding .idea/ to the .gitignore?

I think that has also been brought up in other issues here but that kind of file can be ignored using a master ignore file on your own computer. For example as an OSX user I have to globally ignore DS_Store

See #686 ;-)

Great tip!