bcoin-org/bcoin

`estimatesmartfee` RPC API result inconsistent with Bitcoin Core RPC API (`fee` vs `feerate`)

nkuba opened this issue · 1 comments

nkuba commented

Bitcoin Core RPC API defines the result of estimatesmartfee method to return a feerate property (see: https://developer.bitcoin.org/reference/rpc/estimatesmartfee.html#result).

While Bcoin RPC API returns a fee property instead:

bcoin/lib/node/rpc.js

Lines 2233 to 2236 in 92433b2

return {
fee: fee,
blocks: blocks
};

The fee property should be renamed to feerate to maintain compatibility across the clients.