Don't force Keep Roles and Enrollments or Groups and Groupings to No on import

[ericmerrill]

In course_importer, the keep_roles_and_enrolments is set to false - rather than using the site default, or having a setting. This can be breaking for sites that use something like external database sync to populate their course enrollments into empty shells.

As a workaround we changed the site default for keep_roles_and_enrolments to No and set it to Locked, but that isn't ideal.

[stefanscholz]

Hi Merrill,

thanks for reporting this issue. We'll look into this and will get back to you.
(Please note that we're currently focussing on the release of video time 1.4, i.e. it might be a couple of weeks – if it is more urgent for you, please let me know)

If we need any additional information, we'll get in touch.

Best
Stefan

(for internal reference: KICK-59)

[stefanscholz]

BTW: we're open for pull requests – if you want to propose a solution, that would of course be appreciated.

[ericmerrill]

Note that we actually also the same issue with keep_groups_and_groupings, which is the same issue, in the same part of code, just a second setting, so I'm just adding it on here.

[stefanscholz]

Thanks for raising that! I'll add it to our internal issue as well.