bdrister/AquaticPrime

Inconsistent case sensitivity in sorting key lists

Closed this issue · 6 comments

This leads to mutually incompatible license files in cases where the keys sort differently.

Case-insensitive: Cocoa, PHP, CoreFoundation
Case-sensitive: Python, Ruby, C#

Given the prevalence of the PHP implementation, that algorithm should probably prevail. Should probably also make a stand on diacritic-sensitive sorting, too.

As of 2217857, Ruby is now correctly case-insensitive.

As of 06ba6a6, there's several test cases that can be used to evaluate an implementation's compliance with the "official" signatures.

I wonder why you guys sort keys for hashing... really I cannot imagine why...

Please release AP V2,
get rid of the sorting and sequentially hash key and values as common sense dictates....

As AP is fortunately open source, you or anybody else are welcome to branch it and set up any alternative standards that you like.

You mean "branching" the project just to fix what is currently "nuts" in AP??
No man; my common sense tells me this project has 2 VERY BIG flaws that should be
fixed in a new version of AP not in a new branch of it.

  1. The hash should be performed top down over the "unsorted" license file.
  2. The hash should be performed over "Keys" and Values, not just only on values

Probably the day that you guys decide to address these simple changes this handy project will make a little bit more sense.