bdswiss/country-language

TypeScript definitions

Closed this issue · 8 comments

boenrobot commented

I would like to use this package in a TypeScript application.

I see there hasn't been any activity in 5 years, but that doesn't change the fact that this is a good package for its purpose, and the information is still up to date enough, which is why I'd prefer to use that instead of looking for a more recent one.

This package is simple enough that I can contribute such definitions. @bdswiss, @TassosD, would you accept a PR for this?

pauliusuza commented

@alatzidis might have an answer for this

alatzidis commented

Hello @boenrobot and @pauliusuza

@boenrobot You can add typescript definitions. Please submit a PR about it and I will move this forward.

Have nice weekend

boenrobot commented

Done at #10.

  • 👍1
alatzidis commented

Merged PR. Thanks!

boenrobot commented

Could you also make a release to npm please?

  • 👍3
moritz157 commented

A npm publish with the added typescript definitions would really be awesome 😄

d-luk commented

+1 for the NPM release.

In the meantime you can depend on the commit directly:

# Yarn
yarn add bdswiss/country-language#32091c1

# NPM
npm install --save "git://github.com/bdswiss/country-language#32091c1"
titanism commented

Please switch to use @ladjs/country-language v1.0.0. It is a maintained fork of country-language with zero-dependencies. If you would like to re-add TypeScript definitions, fix bugs, or help to maintain the package, please visit https://github.com/ladjs/country-language.

@ladjs/country-language v1.0.0 release notes can be found at https://github.com/ladjs/country-language/releases/tag/v1.0.0

Thanks to the original authors of this package; we have retained their LICENSE and information in the package as well.