beam-telemetry/telemetry_metrics

Exemplars

Closed this issue · 5 comments

isaacsanders commented

I'm thinking about exemplars lately. If the set of labels that generate exemplars is just another list in the reporter_opts, this library doesn't need to change.

Are there any thoughts on that?

josevalim commented

If the set of labels that generate exemplars is just another list in the reporter_opts, this library doesn't need to change.

It sounds like this is the way to go?

arkgil commented

Yeah, that sounds like the right approach.

isaacsanders commented

Here is a PR that implements exemplars for Prometheus: beam-telemetry/telemetry_metrics_prometheus_core#54

isaacsanders commented

@josevalim Can you point to there this was completed?

josevalim commented

It is not an issue with this library. It goes to reporter_options, as you have described. I guess I could have used the other close command, I am still getting used to that. :)