beardypig/ghidra-emotionengine

Incorrect usage of & instead of &&?

Opened this issue · 4 comments

asmblur commented

ghidra-emotionengine/src/main/java/ghidra/emotionengine/MipsR5900AddressAnalyzer.java

Line 395 in 7a00c5e

if ((refType.isJump() || refType.isCall()) & refType.isComputed()) {

Is this an accidental usage of & instead of &&?

astrelsky commented

ghidra-emotionengine/src/main/java/ghidra/emotionengine/MipsR5900AddressAnalyzer.java

Line 395 in 7a00c5e

if ((refType.isJump() || refType.isCall()) & refType.isComputed()) {

Is this an accidental usage of & instead of &&?

This is a good question. The analyzer is a copy of the MipsAddressAnalyzer in Ghidra with the necessary changes for this plugin.

@emteere if you have a moment may you confirm whether this is correct or not? This is the same as line 388 in MipsAddressAnalyzer.java

beardypig commented

I haven't looked at the return types, but if they are all Boolean then it won't make a difference will it?

astrelsky commented

I haven't looked at the return types, but if they are all Boolean then it won't make a difference will it?

I was thinking about that. It wouldn't matter in c. I'm assuming it wouldn't either in java.

asmblur commented

Technically it should work since "true" is 1 and "false" is 0, so ("true" & "true") == "true". I was just pointing out the bug.