Signed value displayed in unsigned instruction

Question

Signed value displayed in unsigned instruction

Closed this issue 3 years ago · 6 comments

addiu Uses an unsigned value.

It should display:
addiu v0,v0 0xfd80
addiu v1,v1, 0xe330

Answer 1 · 2021-04-27T11:07:11.000Z

Nice catch. May you change simmed to immed in mips.sinc on lines 24 and 25, change sext to zext on line 26, and then submit a pull request please? I'm on my phone and this is a simple fix that you should get credit for.

If you may also fix the li and addu instructions as well it would be appreciated. They are right below addiu.

Answer 2 · 2021-04-27T17:39:36.000Z

I'll try checking it out, hopefully I don't need a Java IDE setup

Answer 3 · 2021-04-27T17:53:37.000Z

Seems like this issue also affects a bunch of other immediate unsigned instructions as well, I'll try to fix those as well

Answer 4 · 2021-04-27T17:56:23.000Z

Yeah looks like that fixed it.

I'll be submitting my fixes as a pr soon

Answer 5 · 2021-04-29T14:14:55.000Z

Closed #55

Answer 6 · 2021-06-08T11:20:11.000Z

addiu Uses an unsigned value.

This is incorrect and a broken assumption for #55.

The only difference to addi is that it shouldn't cause overflow exceptions.
Otherwise it's exactly the same. There's plenty of literature on the topic, but https://webdocs.cs.ualberta.ca/~amaral/courses/229/F04/webslides/Topic6-Logic/tsld005.htm is a good summary.