becheran/mlc

Cannot parse a URL link containing closing parentheses ')'

Closed this issue · 2 comments

Describe the bug
A clear and concise description of what the bug is.
This is a valid URL link, yet mlc cannot parse it correctly

https://en.wikipedia.org/wiki/Stack_(abstract_data_type)

To Reproduce
Steps to reproduce the behavior:

  1. This md file:
    [a Stack data structure](https://en.wikipedia.org/wiki/Stack_(abstract_data_type))

  2. This command '....'
    mlc /path/to/mdfile

  3. See error

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+                                                          +
+        markup link checker - mlc v0.13.7-alpha.0         +
+                                                          +
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

[Err ] ../melvillian.github.io/posts/blah/blah.md (1, 26) => https://en.wikipedia.org/wiki/Stack_(abstract_data_type. 404 - Not Found

Result (1 links):

OK       0
Skipped  0
Warnings 0
Errors   1


The following links could not be resolved:

../melvillian.github.io/posts/blah/blah.md (1, 26) => https://en.wikipedia.org/wiki/Stack_(abstract_data_type.

Expected behavior
A clear and concise description of what you expected to happen.
I expect mlc succeed and return 1 OK and 0 Errors

Desktop (please complete the following information):

  • OS: [e.g. iOS]
    Ubuntu 18.04.5 LTS

  • Browser [e.g. chrome, safari]
    firefox

  • Version [e.g. 22]
    80.0 64-bit

Additional context
I am working on a PR for this right now. My approach is to keep a tally of any additional ( that appear, and only break out of the forward_until when we've reached a matching ).

Sounds like a bug. Thanks for reporting. Let me know if you can/want to fix it yourself or whether I shall help.

Released version 0.13.7 which includes your fix. Many thanks!