Remove all the warnings from the new 'stake' section.
sirbeefalot opened this issue · 9 comments
We've had to add DFI code again to the app. This comes with 1000 different warnings like always. It'd be good to clean them up.
I'd like to give that a go. Are you able to direct me to which file(s) I'll need to clean the code from?
Hi @BrightReach, @fstar just started working on this one. Want me to prepare 1-2 starter issues custom made for you? :)
That would honestly be brilliant!
Genius, will do that. Today I'm not gonna be able due to irl stuff, but I'll do it tomorrow.
Looking forward to working with you. 😁
Hey @BrightReach, i think you can work on this one, as no feedback from @fstar for a long time.
To see warnings simply "yarn start" and you will have bunch of them in logs:
./src/features/stake/sections/StakePools.js
Line 113:62: Unexpected mix of '&&' and '||' no-mixed-operators
Line 113:99: Unexpected mix of '&&' and '||' no-mixed-operators
Line 113:99: Unexpected mix of '||' and '&&' no-mixed-operators
Line 113:125: Unexpected mix of '||' and '&&' no-mixed-operators
Line 113:160: Unexpected mix of '||' and '&&' no-mixed-operators
Line 113:186: Unexpected mix of '||' and '&&' no-mixed-operators
./src/features/vault/components/Pool/Pool.js
Line 1:46: 'useEffect' is defined but never used no-unused-vars
Line 12:10: 'useFetchPoolData' is defined but never used no-unused-vars
./src/features/stake/sections/StakePool.js
Line 43:14: 'i18n' is assigned a value but never used
@roman-monk Was this successfully assigned? If not, I'm happy to tackle it as further introduction to the codebase.
@PCRyan Take it please!
@roman-monk Cool, ready to start, have created myself a branch for it.
Do you want/need to assign me? I see no way to explicitly "take" the issue.