DepositSection should check if allowance is high enough; not just if it is more than 0
ReflectiveChimp opened this issue · 0 comments
ReflectiveChimp commented
Currently the allowance is hard coded to 8000000000 'ether' [1]; user can manually override this in their wallet.
Ideally user could choose to allow an amount equal to their deposit, or allow unlimited (á la 1inch). Hard coding to unlimited would be helpful in the short term.
Either way; the DepositSection should check if the allowance is greater than the amount to be deposited; rather the current check of greater than 0 [2][3][4].
[1]
beefy-app/src/features/web3/approval.js
Line 10 in e1e4f0b
[2]
[3]
[4]