beehive-lab/mambo

Handling "uncond_reg_arm" in traces

alirazeen opened this issue · 2 comments

I have encountered the case where the trace scanner prints the message Unknown exit branch type for the branch type uncond_reg_arm. Do I only have to add it to the if and switch statement in create_trace? Is it as simple as commit 236010f or would I have to take into account something else?

Thank you for all the help, by the way!

lgeek commented

Could you please confirm whether the full message was "Unknown exit branch type in trace head: X"?

If it was, then uncond_reg_arm needs to be added both to the if on line 90 and to the switch starting on line 142 (

mambo/traces.c

Line 142 in 236010f

switch(thread_data->code_cache_meta[thread_data->trace_id-1].exit_branch_type) {
) - not the one on line 194 like in the other commit.

Yep, that was the message, and I did place uncond_reg_arm in the right places. Things proceeded to work after that.