bellstrand/totp-generator

Web Crypto API

Closed this issue · 5 comments

Maybe you could replace jssha package with the Web Crypto API which is pretty much supported everywhere, and would be way faster since it's natively implemented by the runtimes.

@7heMech This is an issue tracker.
Feel free to open a PR if you'd like to contribute additional or improved functionality to this repository.

@bellstrand I'd be happy to contribute, also what do you think about switching to bun (will make tests way faster) would it be fine if I created a PR for that as well?

Also webcrypto api supports only "SHA-1" | "SHA-256" | "SHA-384" | "SHA-512" maybe that's a deal-breaker?

@7heMech Good question, It's not a deal-breaker for me personally. But let me check around some of the open-source repos using this to see which are heavily in use first!

I'm not against switching to bun per-se, but it would require replacing Dependabot as well.
So i'd rather wait for dependabot/dependabot-core#6528 before making that switch :)

I looks like SHA-1 AND SHA-512 covers almost all cases I can find, so I'm all for it.