Drop Logging for ActiveSupport::Logger
Opened this issue · 1 comments
ashtonthomas commented
Napa currently uses the logging
gem which implements its own logger class. ActiveSupport provides a nice extension to Ruby's standard logger
We are already leveraging ActiveSupport so this would eliminate some overhead and get us back closer to standard libraries.
Another benefit is the ActiveSupport::TaggedLogging which makes it really easy to tag logs with whatever we want. This proves to be difficult with the logging
gem (I tried this weekend but had some trouble - seems like you can modify the :pattern
but custom tags may be trickier)
Thoughts?
cc: @bellycard/platform @danielmackey @mbueti
heymackey commented
Sounds like a good optimization, dropping a dependency and getting some benefits 👍