bemusic/bemuse

Fix Sass loader warnings

Closed this issue · 3 comments

dtinth commented

Background

When building Bemuse, the following deprecation warnings appear in the console:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(22em * 9, 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
54 │     height: 22em * 9 / 16;
   │             ^^^^^^^^^^^^^
   ╵
    src/app/ui/ModeSelectScene.scss 54:13  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 7)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
62 │       width: (100% / 7);
   │               ^^^^^^^^
   ╵
    src/app/ui/OptionsInputKeys.scss 62:15  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 7)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
65 │         left: (100% / 7) * 0;
   │                ^^^^^^^^
   ╵
    src/app/ui/OptionsInputKeys.scss 65:16  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 7)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
68 │         left: (100% / 7) * 1;
   │                ^^^^^^^^
   ╵
    src/app/ui/OptionsInputKeys.scss 68:16  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 7)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
71 │         left: (100% / 7) * 2;
   │                ^^^^^^^^
   ╵
    src/app/ui/OptionsInputKeys.scss 71:16  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 7)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
74 │         left: (100% / 7) * 1;
   │                ^^^^^^^^
   ╵
    src/app/ui/OptionsInputKeys.scss 74:16  root stylesheet

WARNING: 4 repetitive deprecation warnings omitted.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($size, 5)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │   border-radius: $size / 5;
   │                  ^^^^^^^^^
   ╵
    src/app/ui/MusicListItemChart.scss 12:18  root stylesheet

Task

  • Please fix all the warnings. When building, that should be no more deprecation warnings.
  • For ease of review, your PR should fix all the warnings, and change nothing else. Only .scss files should be changed.
  • Please make sure all the automated checks are passing.
  • In your PR description, please include a screenshot of each component to confirm that your changes do not break the layout.
vishal5251 commented

Assign this one to me.

dtinth commented

@vishal5251 It’s yours now, thank you very much for taking on this issue. 🙏

For continued progress, the issue will be automatically unassigned after 3 days of inactivity, so please keep me updated. Thanks again! 😄

  • 👍1
dtinth commented

Closed in #689 by @vishal5251. Thank you!!

  • 👍1