bemusic/bemuse

Refactoring: Replace `updeep` with `immer`

dtinth opened this issue · 6 comments

dtinth commented

Background

Bemuse used the updeep library, but after some experience in other projects I think using immer leads to more readable code.

Task

  • Replace updeep with immer.
  • Your PR should migrate all usage of code that uses updeep and replace it with immer. In bemuse/package.json, updeep should be removed from dependencies, and latest version of immer added.
  • All automated checks should pass.

Hacktoberfest

If you would like to work on this task, please write a comment stating your intent. We will then assign the issue to you. To ensure continuity, the issue will be unassigned after 3 days of inactivity — so please keep us updated.

aadityasinha-dotcom commented

Can I work on this issue?

dtinth commented

@aadityasinha-dotcom The issue is now yours, thank you! 🙏

aadityasinha-dotcom commented

@dtinth I have added the latest version of immer in the bemuse/package.json and removed the updeep from the dependencies.

  • 👍1
dtinth commented

@aadityasinha-dotcom I see that the PR is closed — do you plan to continue this some time or should I unassign this for now?

aadityasinha-dotcom commented

@aadityasinha-dotcom I see that the PR is closed — do you plan to continue this some time or should I unassign this for now?

No, I am working on it. Actually that was an incomplete PR so I thought to close that.

dtinth commented

@aadityasinha-dotcom Thanks for the update! Let me know if you need any help. 😃

You can mark your PR as “draft” so that it is clear that the PR is not ready yet.

  • 👍1