ben-biddington/Coriander.Haarlem

CarrotTab isAvailable fails with non-numeric buildId

Closed this issue · 2 comments

This happens when you use one of the "permalinks" at the bottom of any build screen. Other links include "Last successful build" and "Last finished build".

These links look like:

/viewLog.html?buildTypeId=bt5&buildId=lastPinned

rather than:

/viewLog.html?buildId=99&tab=buildResultsDiv&buildTypeId=bt5

Under these alias conditions there is a cached copy of the build at:

request.getAttribute("BUILD_KEY")

which needs to be used rather than:

buildServer.findBuildInstanceById(Long)

This has been fixed in 3804454