ben-eb/gulp-svgmin

Upgrade svgo to version 0.4.5

roadhump opened this issue · 4 comments

roadhump commented
Upgrade svgo to version 0.4.5
ben-eb commented

👍

ben-eb commented

ping @nfroidure - sorry to bother you but this fails my build, I was wondering if it had anything to do with the bufferstreams lib? Still works fine with buffers, but no luck with the stream mode. I did try downgrading back to svgo 0.4.4 which wasn't the issue... Any advice would be appreciated 😃

1) gulp-svgmin stream mode should minify svg with svgo:
     Uncaught AssertionError: expected { Object (0, 1, ...) } to equal '<svg xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="40" fill="#ff00"/></svg>'
      at /home/travis/build/ben-eb/gulp-svgmin/test.js:104:37
      at Stream.<anonymous> (/home/travis/build/ben-eb/gulp-svgmin/node_modules/event-stream/index.js:300:20)
      at _end (/home/travis/build/ben-eb/gulp-svgmin/node_modules/event-stream/node_modules/through/index.js:65:9)
      at Stream.stream.end (/home/travis/build/ben-eb/gulp-svgmin/node_modules/event-stream/node_modules/through/index.js:74:5)
      at BufferStream.onend (/home/travis/build/ben-eb/gulp-svgmin/node_modules/bufferstreams/node_modules/readable-stream/lib/_stream_readable.js:505:10)
      at BufferStream.g (events.js:180:16)
      at BufferStream.emit (events.js:117:20)
      at /home/travis/build/ben-eb/gulp-svgmin/node_modules/bufferstreams/node_modules/readable-stream/lib/_stream_readable.js:942:16
      at process._tickCallback (node.js:419:13)

https://travis-ci.org/ben-eb/gulp-svgmin

ben-eb commented

@roadhump Fixed in 0.4.7.

nfroidure commented

Missed it. Sorry about that.