Incorrect exceeded version reported in HTML report, while correct version is reported in console output

[jayasuryat]

Hi @ben-manes,
Thanks for this awesome plugin.

I recently encountered this issue, where while reporting exceeded versions, the plugin correctly reports the Latest version in the console output, but in the HTML report the Current version is being reported as the Latest version.

---

I did some quick digging in the source code, and found this :

gradle-versions-plugin/gradle-versions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/reporter/HtmlReporter.kt

Lines 335 to 344 in bb9be6e

	getVersionString(
	dependency.group.orEmpty(),
	dependency.name.orEmpty(),
	dependency.version
	),
	getVersionString(
	dependency.group.orEmpty(),
	dependency.name.orEmpty(),
	dependency.version
	),

Looks like the same value dependency.version is being printed for both Current version & Latest version (instead of dependency.latest (I'm assuming)).

While I assumed that this issue is valid and the thing I found is the cause, I could be wrong. I got a bit curious and did some quick digging.

[ben-manes]

It might have been a mistake from the Groovy rewrite to Kotlin. You might look at the original Groovy code to confirm. PRs are always welcome

[jayasuryat]

Looks like this also existed in the groovy version:

gradle-versions-plugin/src/main/groovy/com/github/benmanes/gradle/versions/reporter/HtmlReporter.groovy

Lines 169 to 172 in b53e44f

	rowString = String.format(rowStringFmt, item.getName(), item.getGroup(),
	getUrlString(item.getProjectUrl()), getVersionString(item.getGroup(), item.getName(), item.getVersion()),
	getVersionString(item.getGroup(), item.getName(), item.getVersion()),
	item.getUserReason()?:'')

---

While the PlainTextReporter seems to be correct in the both versions

PlainTextReporter - Kotlin

gradle-versions-plugin/gradle-versions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/reporter/PlainTextReporter.kt

Lines 70 to 71 in bb9be6e

	val currentVersion = dependency.version
	printStream.println(" - ${label(dependency)} [$currentVersion <- ${dependency.latest}]")

PlainTextReporter - Groovy

gradle-versions-plugin/src/main/groovy/com/github/benmanes/gradle/versions/reporter/PlainTextReporter.groovy

Lines 127 to 128 in b53e44f

	def currentVersion = dep.version
	printStream.println " - ${label(dep)} [${currentVersion} <- ${dep.latest}]"

---

Thanks for the quick response @ben-manes, I'd love to contribute the fix for this. Let me know if my understanding of the existence of the issue sounds right to you.

[ben-manes]

Yep, it looks like it was maybe changed in #508 where that method used to use the "available version" but had a refactoring mistake. In the original contribution it called item.getLatest().

[jayasuryat]

@ben-manes I've created a PR with the change, the said change only changes the dependency.version to dependency.latest.

I didn't find any tests that needed to be updated, altho some tests are failing only in the DifferentGradleVersionsSpec class, (rest all test classes are passing fine). From what I could understand these were due to Java version mismatch.

Let me know if there is anything else needed to be updated.

[ben-manes]

The tests pass on CI, so I think you're fine too.

I tried it locally by bumping the version, running publishToMavenLocal, and checking the report generated by examples/groovy (which sources the latest from mavenLocal if available). It looked perfect to me.

[jayasuryat]

Glad to know that everything is working as expected.

This was super quick, thanks @ben-manes.