bencherdev/bencher

Handle long archived branch names

epompeii opened this issue · 1 comments

Taking a look at the log output: https://github.com/firezone/firezone/actions/runs/10502113994/job/29094848072#step:6:86
There seems to be an issue with the length of the branch name that Bencher is generating due to a chain of archived branches, which generates a 409 error.

has conflict: Failed to validate branch name: fix/gateway-no-resolve-domains-without-socket@feat/ignore-unsupported-dns-servers@fix/discard-socket-on-destination-host-unreachable@main/hash/2aa667f9ea226f728094c20dc9bc6dde02b762a0/hash/f475e3860ef4a41234de891842a399fb24402171/hash/7029636a790ea0a024da466754f2d64ab5e55594

Completed: https://bencher.dev/docs/reference/changelog/#v0419

The start point branch name was only included in the archived branch name for historical reasons, before the start point was preserved in the Branch model. Now that the start point is part of the model, it makes more sense to just use the UUID as part of the archived Branch names. This should fix this issue in all but the most extreme cases of long branch names.