Upgrade bluebird or be more permissive

Question

Upgrade bluebird or be more permissive

Marsup opened this issue 10 years ago · 4 comments

Hi,

The bluebird version you are using is quite old and is actually "leaking" (probably intentional) a global __BluebirdErrorTypes__. Could you at least upgrade it or consider being more permissive about it ?

Thanks.

Answer 1 · 2014-08-19T10:50:02.000Z

For sure — updated to ^2.3.0 in 78f8674 and releasing as v1.0.0. Almost did '>= 1' but held off. I'm a fan of Hapi's convention of rapid major releases with breaking changes. Even though promisify is unlikely to change I figure it's best to stick to semver and bump the dependency as appropriate.

Answer 2 · 2014-08-19T11:07:10.000Z

Since stream-to-array already returns a promise, you don't even need promisify.

Answer 3 · 2014-08-19T11:08:55.000Z

Oh but you're still using 1.0 on this dependency as well.

Answer 4 · 2014-08-19T11:17:04.000Z

Updating to 2.0 in #5