bendudson/BOUT

Domain labelling for boundary conditions

bendudson opened this issue · 1 comments

Global variable MYPE_IN_CORE is used by boundary.cpp to distinguish between boundary conditions for the "core" boundary, and the "private flux" / "pf" boundary which are both at X=0 on different processors, but generally need different handling.

The distinction between "core" and "pf" is specific to tokamaks, and in general a different labelling would be required. What should happen is:

The mesh class labels its regions however it wants. In the option file, boundary settings are looked for with names. Mesh provides a list of domain labels and a means to loop over them.

First the domain-specific settings: bndry_ = ...
Failing that, an "inner/outer" e.g. bndry_xinner = .... and bndry_yup = ...
Finally a general bndry = ...

This could/should be done by finishing the tables system in boundary.cpp (which isn't currently used)

This is fixed by 3fa4cce

Each mesh defines a set of boundary regions