benevbright/react-navigation-collapsible

Status bar and padding on Expo

Closed this issue · 6 comments

When using expo with a translucent status bar, top padding is correct.

But when setting the status bar to Hidden or not Translucent (with app.json or with StatusBar class), padding top is not correct anymore. Seems like padding calculations still use the status bar height when it should be 0.

Yes, I confirm this problem.
The problem is that this module treats Expo always use translucent header and react-native init always not.

return global.Expo ? StatusBar.currentHeight : 0;

It should be fixed so the status header height gets calculated according to the user option.

related with #116

Hi @benevbright, do you think it will be fix soon ?
Thanks

Not sure if it's related, but I have a specific height for my header which is 60.
I can notice when I use the createCollapsibleStack, a small part (on top) of my component goes behind the header.

BUG only on IOS.

Working with :

"@react-native-community/masked-view": "0.1.5",
"@react-navigation/drawer": "^5.5.1",
"@react-navigation/native": "^5.1.7",
"@react-navigation/stack": "^5.2.14",
...
"react-navigation-collapsible": "^5.5.0",

Hi, @ozerty
There was a problem when using custom headerStyle.height. #130 This PR fixed it.

I will fix the status problem soon and release them together.

@Keplyx Please check this PR, #131.
It's not a smart solution but you can prevent the status height from being calculated.

v5.6.0 includes #130 and #131.