bengarrett/RetroTxt

[FEATURE] Clickable links

Akababa opened this issue · 5 comments

Akababa commented

Is your feature request related to a problem? Please describe.
When using RetroTxt to view logfiles, links are not clickable

Describe the solution you'd like
I would like https:// to be clickable

bengarrett commented

Thanks for the suggestion @Akababa. It wasn't implemented in the past as there would be a performance hit to the rendering, and it would sometimes fail to work. For example, links in ANSI docs with multiple colors or styles could be broken.

I could add this ability and have a Setting toggle set to off by default.

Akababa commented

That would be great! I use this for opening log files in my browser, some of which include links.

bengarrett commented

Due in v5.2.

  • 🎉1
Akababa commented

Thanks! I just tried it out and it works well. But if it's not too hard, it would be even better if you could have an option to only replace strings starting with https:// to reduce false positives and improve performance.

bengarrett commented

Thanks, the clickable links feature is a complicated task and uses a 3rd party dependency, https://github.com/Hypercontext/linkifyjs. The options and accuracy is limited to what is provided by the package, but at least it should be performant given the number of users and contributors.