Missing square root in scores for scan_eb_negbin?
paulsromer opened this issue · 2 comments
paulsromer commented
I've been digging into this package, and I noticed that you're using the formula sum((y - m) / w) / sum(m / w)
to calculate "hotspot" scores for the scan_eb_negbin
function, but Tango et al. (2011) use the formula sum((y-m) / w) / sqrt(sum(m / w))
. Was there a deliberate reason for this change or is this a bug?
Thanks,
-Paul
Deleted user commented
Hi! I'm no longer actively maintaining the package, but I think @ellereve might do so in the future. However, I could look into this bug and fix it if it is indeed wrong. Thanks for spotting it!
ellereve commented
Hi @paulsromer, thanks for spotting that. Perfect timing, as I am currently preparing a very small update to the package for CRAN. I'll inform you as soon as this issue is resolved.
-Kelly