benjamin-wilson/public-pool

Question: What could be wrong with this "mining.authorize" message?

Closed this issue · 2 comments

KaSt commented

Good day,
as someone reported some time ago, some miners, old miners I gather, aren't compatible with this wonderful pool.
In this case I'm talking about bfgminer 5.5.0 which I run on a Onion Omega 2+ (openwrt) with some old USB miners.

The "mining.authorize" message doesn't pass validation. I never used nextjs and not a Stratum expert but the only thing I noticed is that the message id in this case is not numeric, the "subscribe" one is.

What could be wrong with this message?
{"id": "auth", "method": "mining.authorize", "params": ["my Bitcoin address was removed", "x"]}

I tried to check the pool code for the validation performed but so far could only find the validation of the params section, based on the "mining.authorize" method.

In case somebody has an idea.

Thanks for the great work.

Currently the id must be numeric:

@IsNumber()
id?: number = null;

I can't see any strict requirement for this elsewhere in the codebase, and stratum mining lacks formal spec, so expect this could be removed for better compatibility.

Removed the requirement
f08103b