bergie/hallo

Hallolink doesn't restore selection correctly ?

buzzmeeks opened this issue · 0 comments

(On Chrome 31.0.1650.57)

Hello,

In the Hallolink plugin, document.execCommand("createLink", null, link) returns FALSE, and the link is not created.

Logging the window.getSelection() right before the execCommand has this result :

Selection {type: "Range", extentOffset: 1, extentNode: form.linkForm, baseOffset: 1, baseNode: form.linkForm…}
anchorNode: text
anchorOffset: 0
baseNode: text
baseOffset: 0
extentNode: text
extentOffset: 0
focusNode: text
focusOffset: 0
isCollapsed: true
rangeCount: 1
type: "Caret"
proto: Selection

Where the window.getSelection() of the piece of text I want to create a link on gives :

Selection {type: "Range", extentOffset: 8, extentNode: text, baseOffset: 0, baseNode: text…}
anchorNode: text
anchorOffset: 0
baseNode: text
baseOffset: 0
extentNode: text
extentOffset: 8
focusNode: text
focusOffset: 8
isCollapsed: false
rangeCount: 1
type: "Range"
proto: Selection

Is there a problem with the restoration of the selection after the link dialog has been opened ?