berinhard/model_mommy

Django 2.0: set() got an unexpected keyword argument 'bulk'

karyon opened this issue · 3 comments

this line in model mommy throws this error for me with django 2.0:

TypeError: set() got an unexpected keyword argument 'bulk'"

called from my project here

fwiw, for me it only happens on the UserProfile, which has a custom manager

django has two such set methods, here and here, only the first of which has the parameter bulk.

breaking commit in django is here

@karyon, currently there's an open PR to run the tests with Django 2.0 (here #347). Once we have the tests running, we'll be able to debug this error properly.

hey, do you still have this on your radar? is there any chance you will fix this any time soon? i could try to fix it myself, but don't know when i'll find the time, and a little guidance would be nice as well...

@karyon we've added django 2.0 support already. Now I think is safe for you to work on this if you can. You can start by writing a test reproducing the error you've described and them implement the code to make it pass. Probably you can add you test near to these ones.