berry-lang/berry

Evaluate Profile-Guided Optimization (PGO) and LLVM BOLT

zamazan4ik opened this issue · 3 comments

Hi!

Recently I did many Profile-Guided Optimization (PGO) benchmarks on multiple projects (including interpreters and compilers like CPython, Rustc, Clang, GCC, and many others) - the results are available here. So that's why I think it's worth trying to apply PGO to Berry tooling.

I can suggest the following things to do:

  • Evaluate PGO's applicability to Berry tooling with benchmarks.
  • If PGO helps to achieve better performance - add a note to Berry's documentation about that. In this case, users and maintainers will be aware of another optimization opportunity for Berry.
  • Provide PGO integration into the build scripts. It can help users and maintainers easily apply PGO for their own workloads.

Here are some examples of how PGO is already integrated into other projects' build scripts:

After PGO, I can suggest evaluating LLVM BOLT as an additional optimization step after PGO.

skiars commented

This should be able to be added once CMake build scripts #370 are supported? I'm not going to do this in Makefile because CMake is better.

This should be able to be added once CMake build scripts #370 are supported? I'm not going to do this in Makefile because CMake is better.

If you are talking about integrating PGO build mode directly to the build scripts - yeah, it could be integrated directly into the CMake scripts. As an example, you can look at the following projects:

However, you can add PGO support even without CMake (e.g. via a dedicated Makefile command) - it's all up to you.

skiars commented

I want to do it in CMake because it's cross-platform and can generate Makefiles.