New installations are broken because of upstream issue for detectron2

Question

New installations are broken because of upstream issue for detectron2

Closed this issue a year ago · 7 comments

stweil commented a year ago

Building works, but running ocrd-detectron2-segment with make check raises an exception.

See related upstream issue facebookresearch/detectron2#5010.

Until upstream is fixed, pip install -U "pillow<10.0.0" helps.

Answer 1 · 2023-07-03T14:36:01.000Z

Strange that this did not hit us in the Docker build (also Py38).

Since it's unlikely this will get fixed in detectron2 any time soon (last release is from 2021), but we do not use this anywhere else in ocrd_all, would you recommend adding pillow<10.0 here in requirements.txt?

Answer 2 · 2023-07-03T14:47:52.000Z

Pillow 10.0.0 (which causes the breakage) was released on July 1, so it's not surprising that your or my previous builds passed fine. ~~And yes, updating the requirements seems to be the only possible solution.~~ Instead of updating the requirements (which would cause downgrades of pillow during the build process), it might be better to patch detectron2 after it was installed.

Answer 3 · 2023-07-03T15:05:01.000Z

was released on July 1, so it's not surprising that your or my previous builds passed fine.

It is surprising – the latest Docker build is just 2h ago.

Instead of updating the requirements (which would cause downgrades of pillow during the build process), it might be better to patch detectron2 after it was installed.

I would not know how to do this (properly). Using make deps, Detectron2 gets pulled from git and then compiled as a temporary wheel before getting installed into the current venv...

Answer 4 · 2023-07-03T16:28:30.000Z

I think I found a clean way.

Can you please try #28?

Answer 5 · 2023-07-03T16:42:05.000Z

The pull requests #27 and #28 basically do the same thing to fix this issue. They only use slightly different ways to find the location of the installed detectron2 and to patch the code. It's your choice which one you prefer.

Answer 6 · 2023-07-10T18:44:33.000Z

detectron2 was recently updated (July 6, 2023) so that this issue is now fixed. You should be able to use Pillow==10.0.0 now.

facebookresearch/detectron2@ff53992

Answer 7 · 2023-07-10T21:22:15.000Z

Thanks @rayryeng for letting me know!

Unfortunately, we still require released version v0.6 here, and there has been no release since then for over 2 years. I cannot see what ramifications the switch to master would have for (the performance of) all the models that we redistribute here...