beryx/badass-runtime-plugin

Setting installerOutputDir only producers a single installer

Closed this issue · 4 comments

If I set installerOutputDir, e.g. installerOutputDir = file("releases") and run jpackage under Windows 10, using JDK14, gradle 6.3, it only produces an .msi package.

Expected results: .exe and .msi packages

Commenting out installerOutputDir and using outputDir instead I get both installers.

*note: installerType is not being set/used

Fixed in 1.8.3.

@siordache Sorry but got another use case for you :)

The above works now unless you now also add '--temp', 'releases/temp-files', as an installerOptions I assume when it's time to create the .msi it's running the command again and wants a clean temp dir.

Starting process 'command 'C:\Users\Jamz\.jabba\jdk\adopt@1.14.0-0/bin/jpackage.exe''. Working directory: C:\Users\Jamz\Development\git\JamzTheMan\MapTool Command: C:\Users\Jamz\.jabba\jdk\adopt@1.14.0-0/bin/jpackage.exe --type msi --dest C:\Users\Jamz\Development\git\JamzTheMa
n\MapTool\releases --name MapTool --app-image C:\Users\Jamz\Development\git\JamzTheMan\MapTool\build\jpackage\MapTool --resource-dir C:\Users\Jamz\Development\git\JamzTheMan\MapTool\package\windows --verbose --temp releases/temp-files --description SNAPSHOT-ae52179 --copyright
Copyright 2000-2020 RPTools.net --license-file package/license/COPYING.AFFERO --app-version 1.8.11 --vendor Nerps --file-associations package/associations.properties --win-dir-chooser --win-per-user-install --win-shortcut --win-menu --win-menu-group Nerps
Successfully started process 'command 'C:\Users\Jamz\.jabba\jdk\adopt@1.14.0-0/bin/jpackage.exe''
WARNING: Using incubator modules: jdk.incubator.jpackage
jdk.incubator.jpackage.internal.PackagerException: Error: temp (releases/temp-files) must be non-existant or empty directory
        at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.DeployParams.validate(DeployParams.java:261)
        at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Arguments.processArguments(Arguments.java:486)
        at jdk.incubator.jpackage/jdk.incubator.jpackage.main.Main.execute(Main.java:97)
        at jdk.incubator.jpackage/jdk.incubator.jpackage.main.Main.main(Main.java:51)

Try it again with 1.8.4. It should work now.

Awesome, worked like a charm now. thanks!